Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebSocket server now indefinitely keeps track of non-data RPC commands #8146

Merged
merged 1 commit into from
Nov 14, 2024
Merged

WebSocket server now indefinitely keeps track of non-data RPC commands #8146

merged 1 commit into from
Nov 14, 2024

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Nov 14, 2024 •
edited by github-actions bot
Loading

@teh-cmc teh-cmc added 🪳 bug Something isn't working 🕸️ web regarding running the viewer in a browser user-request This is a pressing issue for one of our users include in changelog labels Nov 14, 2024
Wumpf
Wumpf approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@teh-cmc teh-cmc merged commit 00309df into main Nov 14, 2024
46 checks passed
@teh-cmc teh-cmc deleted the cmc/fix_buggy_workaround branch November 14, 2024 14:54
teh-cmc added a commit that referenced this pull request Nov 14, 2024
@teh-cmc
WebSocket server now indefinitely keeps track of non-data RPC commands (
6e9d7b9 
#8146)

* Fixes #5344
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
🪳 bug Something isn't working include in changelog user-request This is a pressing issue for one of our users 🕸️ web regarding running the viewer in a browser
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New clients do not receive data in Web-Viewer mode after dropping old messages
2 participants
@teh-cmc @Wumpf